MPFProj10 Issue Tracker Rss Feed

Created Issue: Folder defined in project templates will not be created physically [12521]

humbrie — Wed, 24 Oct 2012 11:05:23 GMT

Folder (and their contents) will not get created, if they are defined in a vstemplate (project). Instead i had to overwrite the CreateFolderNode method in class ProjectNode.

But the FolderNotes appear in the Solution Explorer. In fact, they are degraded to some kind of solution folder.

If an item got dragged or added to the FolderItem, the folder will be created ad hoc.
(VS 2010 SP1)

Commented Issue: Project reference doesn't work correctly if referenced project is in a solution folder [10801]

ldubois — Wed, 29 Aug 2012 00:31:12 GMT

1. Create a Solution folder
3. Create a C# project inside the just created folder.
4. Create a whatever project using MPF (Visual T# in the attached Image)
5. Make a reference from MPF project to C# project: an exclamation sign appears. Reference is not resolved and Intellisense does not work!

See attached image.
Comments: ** Comment from web user: ldubois **

@kiquenet, this is a method provided by MPF that compare two paths and returns true iif they are equal.

Commented Issue: Project reference doesn't work correctly if referenced project is in a solution folder [10801]

kiquenet — Tue, 28 Aug 2012 12:13:43 GMT

@idubois, What is NativeMethods.IsSamePath ?

Created Issue: Unhandled COMException in internal static method GetActiveConfigurationName(EnvDTE.Project automationObject) of Utilities [12424]

richarddzh — Sun, 05 Aug 2012 04:39:53 GMT

When I provide my own project type with the following template, exception is thrown as I close projects of my own type.
Exception is thrown in Line 404 of Utilities.cs.
My project template is like this:
<Project DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
<PropertyGroup>
<Configuration Condition=" '$(Configuration)'=='' ">Debug</Configuration>
<ConfigurationName Condition=" '$(ConfigurationName)' == '' ">$(Configuration)</ConfigurationName>
<OutputPath Condition=" '$(OutputPath)'=='' ">output\Debug</OutputPath>
</PropertyGroup>
<Target Name="Build">
<Message Text="It is an empty target." />
</Target>
</Project>

The code where unhandled COMException is thrown.

internal static string GetActiveConfigurationName(EnvDTE.Project automationObject)
{
if(automationObject == null)
{
throw new ArgumentNullException("automationObject");
}
string currentConfigName = string.Empty;
if(automationObject.ConfigurationManager != null)
{
>>>>EnvDTE.Configuration activeConfig = automationObject.ConfigurationManager.ActiveConfiguration;
if(activeConfig != null)
{
currentConfigName = activeConfig.ConfigurationName;
}
}
return currentConfigName;
}

Commented Issue: ProjectConfig.get_CanonicalName returns display name instead of the canonical name [12178]

dinov — Tue, 22 May 2012 22:55:34 GMT

DisplayName is documented as being in the form "<configname>|<platform name>" http://msdn.microsoft.com/en-us/library/bb139670(v=VS.80).aspx

CanonicalName is just the config name such as "Debug" or "Release" http://msdn.microsoft.com/en-us/library/microsoft.visualstudio.shell.interop.ivsprojectcfg.get_canonicalname(v=VS.80).aspx

In MPFProj get_CanonicalName just calls get_DisplayName, so a string such as "Debug|AnyCPU" is passed out when it should just be "Debug".

The fix is to make get_CanonicalName just to do:

public virtual int get_CanonicalName(out string name)
{
name = configName;
return VSConstants.S_OK;
}
Comments: ** Comment from web user: dinov **

If you are using MPFProj w/ Dev11 and are getting an error about x64 and ARM targets not being supported in the WPF designer you might want this fix.

Created Issue: ProjectConfig.get_CanonicalName returns display name instead of the canonical name [12178]

dinov — Tue, 22 May 2012 21:28:58 GMT

Commented Issue: Adding a folder when the folder already exists differs from C# [11519]

KlausGuetter — Fri, 13 Jan 2012 07:57:48 GMT

Select a folder, Project->New Folder, type in a folder name that exists on disk but not in the project system.

In MPFProj this reports an error that the folder already exists.

In C# this adds the existing folder.

The difference here is that MPFProj always immediately adds the folder including attempting to create the directory. The C# project system waits until the call to SetEditLabel to actually do the work of creating the directory and doesn't care if it already exists.
Comments: ** Comment from web user: KlausGuetter **

The proposed fix has a problem with subordinate folders: the VirtualNodeName is set wrong in this case which leads to the problem that files added to the new subordinate folder A\B\C end up in projectdir\C.

To fix, replace the line
this.VirtualFolderName = filename;
by
this.VirtualFolderName = Path.Combine(Parent.VirtualFolderName, filename);
in FinishFolderAdd

Created Issue: Copy and pasting a folder with multiple items throws an exception (WalkSourceProjectAndAdd adds item to incorrect parent) [11618]

dinov — Thu, 12 Jan 2012 21:05:56 GMT

ProjectNode.CopyPaste contains the following code to recursively add all of the siblings when copying a folder within a project:

// Then look at siblings
currentItemID = itemId;
while(currentItemID != VSConstants.VSITEMID_NIL)
{
variant = null;
ErrorHandler.ThrowOnFailure(sourceHierarchy.GetProperty(itemId, (int)__VSHPROPID.VSHPROPID_NextVisibleSibling, out variant));
currentItemID = (uint)(int)variant;
WalkSourceProjectAndAdd(sourceHierarchy, currentItemID, targetNode, true);
}

But to properly walk the list of siblings it needs to pass currentItemId to sourceHierarchy.GetProperty instead of passing itemId. By passing itemId it is repeatedly adding the same node multiple times. Ultimately this results in AddItemWithSpecific returning ADDRESULT_Cancel because of this check:

// If the file to be added is an existing file part of the hierarchy then continue.
if (NativeMethods.IsSamePath(file, newFileName))
{
result[0] = VSADDRESULT.ADDRESULT_Cancel;
continue;
}

And then AddNodeIfTargetExistInStorage throws an Exception with no message which propagates out to the user.

Changing to itemId to currentItemId causes the copy and paste to succeed.

Commented Issue: Adding a folder when the folder already exists differs from C# [11519]

dinov — Thu, 08 Dec 2011 00:14:19 GMT

This change set includes my fix for this: http://pytools.codeplex.com/SourceControl/changeset/changes/a24a50158934

Created Issue: Adding a folder when the folder already exists differs from C# [11519]

dinov — Thu, 08 Dec 2011 00:03:44 GMT

Created Issue: Copying nodes with dependent nodes [11347]

KlausGuetter — Tue, 11 Oct 2011 06:01:21 GMT

There is some support for handling of dependent nodes in MPF (e.g. renaming, deleting), but it seems not to be complete.

When copying (via clipboard or d&d) a node which has some dependent nodes, MPF currently only copies the parent node.

Did anyone already succeed in fixing this?

Created Issue: OAAssemblyReference.Identity should return BaseReferenceNode.AssemblyName.Name, not FullName [11274]

dinov — Thu, 15 Sep 2011 21:20:37 GMT

The docs say this should return "Assembly name (assembly name without path or extension)". That's a little vague on whether it should be the full name including strong name, culture, etc... or if it should just be the simple name.

But the way the Cider designer uses this it expects the simple name. It calls the other properties to get the culture, version, etc... and stores the result of Identity into the Name property of an AssemblyName object. When this name is the full name this results in the commas being escaped and having an assembly name which is totally bogus.

Commented Issue: SingleFileGenerator doesen't truncate the generated file in Iso-Shell [10727]

ldubois — Wed, 07 Sep 2011 15:09:11 GMT

The Method UpdateGeneratedCodeFile in the class SingleFileGenerator has two bugs:

1) If it is running in the Iso-Shell the generated file isn't truncated if it is shorter than befor. You can fix this by changing the line (around line 291)
using (FileStream generatedFileStream = File.Open(filePath, FileMode.OpenOrCreate))
to
using (FileStream generatedFileStream = File.Open(filePath, FileMode.Create))

2) If the generated file is open in visual studio it is *not* generated. I'll fix it by generating always. To do this I'll comment out the lines from 'if(docData != IntPtr.Zero)' until the 'else' block.
Comments: ** Comment from web user: ldubois **

I'm OK with first point.

But second point is because of a missing line of code: GetBufferContents( filePath, srpStream ); between IVSTextStream srpStream = null; and if( srpStream != null )

I also changed code so that in memory changed failure => save it on disk

IVsHierarchy hier;
uint cookie;
uint itemid;
IntPtr docData = IntPtr.Zero;
ErrorHandler.ThrowOnFailure(rdt.FindAndLockDocument((uint)(_VSRDTFLAGS.RDT_NoLock), filePath, out hier, out itemid, out docData, out cookie));
bool changedInMemory = false;
if(docData != IntPtr.Zero)
{
Marshal.Release(docData);
IVsTextStream srpStream = null;
GetBufferContents( filePath, out srpStream ); // Missing line ?!?!?
if(srpStream != null)
{
int oldLen = 0;
int hr = srpStream.GetSize(out oldLen);
if(ErrorHandler.Succeeded(hr))
{
IntPtr dest = IntPtr.Zero;
try
{
dest = Marshal.AllocCoTaskMem(data.Length);
Marshal.Copy(data, 0, dest, data.Length);
ErrorHandler.ThrowOnFailure(srpStream.ReplaceStream(0, oldLen, dest, size / 2));
changedInMemory = true;
}
finally
{
if(dest != IntPtr.Zero)
{
Marshal.Release(dest);
}
}
}
}
}
if( !changedInMemory )
{
using(FileStream generatedFileStream = File.Open(filePath, FileMode.Create)) // not OpenOrCreate for the file to be truncated if necessary
{
generatedFileStream.Write(data, 0, size);
}

EnvDTE.ProjectItem projectItem = fileNode.GetAutomationObject() as EnvDTE.ProjectItem;
if(projectItem != null && (this.projectMgr.FindChild(fileNode.FileName) == null))
{
projectItem.ProjectItems.AddFromFile(filePath);
}
}
return filePath;

Commented Issue: Project reference doesn't work correctly if referenced project is in a solution folder [10801]

ldubois — Mon, 18 Apr 2011 13:55:24 GMT

Here is my patche (in ProjectReferenceNode.cs):

/// <summary>
/// Gets the automation object for the referenced project.
/// </summary>
internal EnvDTE.Project ReferencedProjectObject
{
get
{
// If the referenced project is null then re-read.
if (this.referencedProject == null)
{
// Search for the project in the collection of the projects in the
// current solution.
EnvDTE.DTE dte = (EnvDTE.DTE)this.ProjectMgr.GetService( typeof( EnvDTE.DTE ) );
if( ( null == dte ) || ( null == dte.Solution ) )
{
return null;
}

foreach( EnvDTE.Project prj in dte.Solution.Projects )
if( IsOrContainReferencedProject( prj ) )
break;
}

return this.referencedProject;
}
set
{
this.referencedProject = value;
}
}

private bool IsOrContainReferencedProject( EnvDTE.Project prj )
{
//Skip this project if it is an umodeled project (unloaded)
if( string.Compare( EnvDTE.Constants.vsProjectKindUnmodeled, prj.Kind, StringComparison.OrdinalIgnoreCase ) == 0 )
{
return false;
}
if( string.Compare( EnvDTE.Constants.vsProjectKindSolutionItems, prj.Kind, StringComparison.OrdinalIgnoreCase ) == 0 )
{
foreach( EnvDTE.ProjectItem projectItem in prj.ProjectItems )
{
EnvDTE.Project project = projectItem.Object as EnvDTE.Project;
if( project != null &&
IsOrContainReferencedProject( project ) )
return true;
}
return false;
}

// Get the full path of the current project.
EnvDTE.Property pathProperty = null;
try
{
if( prj.Properties == null )
{
return false;
}

pathProperty = prj.Properties.Item( "FullPath" );
if( null == pathProperty )
{
// The full path should alway be availabe, but if this is not the
// case then we have to skip it.
return false;
}
}
catch( ArgumentException )
{
return false;
}
string prjPath = pathProperty.Value.ToString();
EnvDTE.Property fileNameProperty = null;
// Get the name of the project file.
try
{
fileNameProperty = prj.Properties.Item( "FileName" );
if( null == fileNameProperty )
{
// Again, this should never be the case, but we handle it anyway.
return false;
}
}
catch( ArgumentException )
{
return false;
}
prjPath = System.IO.Path.Combine( prjPath, fileNameProperty.Value.ToString() );

// If the full path of this project is the same as the one of this
// reference, then we have found the right project.
if( NativeMethods.IsSamePath( prjPath, referencedProjectFullPath ) )
{
this.referencedProject = prj;
return true;
}
return false;
}

Created Issue: Project reference doesn't work correctly if referenced project is in a solution folder [10801]

ldubois — Mon, 18 Apr 2011 13:14:02 GMT

Commented Issue: Delete Key is not supported for Project FileNode and FolderNodes [10029]

tsgd84 — Thu, 14 Apr 2011 08:48:40 GMT

Requirement:
Pressing Del key when the focus is in FileNode/FolderNode at Solution Explorer shall remove the selected item from the project and delete the item from physical disk.

Modifications done to MPF source to accomplish the above behavior:

Uncomment the following line in the QueryStatusOnNode override of FileNode
//case VsCommands.Delete: goto case VsCommands.OpenWith;

Note: IVsHierarchyDeleteHandler is implemented in HierarchyNode

Added the following piece of code in ExecCommandOnNode implementation of FileNode.cs

if(cmdGroup == VsMenus.guidStandardCommandSet97)
{
case VsCommands.Delete:
MessageBox.Show("Del Key Pressed");
return VsConstants.S_OK;
}

After building the solution, I can see the delete context menu with 'Del' key bonded with the Delete command [possibly cmdiddelete] when i right click the filenode. But pressing the Del key doesn't show the message box.

Expected result:
If Del key is pressed when the focus is at FileNode of Solution Explorer, the message "Del Key Pressed" should popup.

Actual result:
The message box "Del key pressed" is not poped up.

It seems like del key binding has some issues with MPF with respect to FileNode and FolderNode.

Following are some of the support threads raised in vsx forum,
http://social.msdn.microsoft.com/Forums/en/vsx/thread/1931a5b0-094f-4060-a247-946fb9cda8d8
Comments: ** Comment from web user: tsgd84 **

Yes, that works!!

Commented Issue: Delete Key is not supported for Project FileNode and FolderNodes [10029]

lesta — Mon, 11 Apr 2011 08:28:24 GMT

Simply add in the constructor of your ProjectNode derived class:
this.CanProjectDeleteItems = true;

Created Issue: SingleFileGenerator generates only the first dependent file [10728]

lesta — Mon, 11 Apr 2011 08:23:22 GMT

The method InvokeGenerator(FileNode fileNode) in the class SingleFileGenerator always generate the first file which depends on the main file. Since more than one file could depend on a file we have to fint the correct file to generate. Fix this with the following code:

while(dependentNode != null)
{
if (dependentNodeName == ((FileNode)dependentNode).FileName // ADDED LE: Lesta you can have more than one file which DependentUpon filenode but only the first one was generated e.g. a *.diagram file and a code file
&& string.Compare(dependentNode.ItemNode.GetMetadata(ProjectFileConstants.DependentUpon), fileNode.FileName, StringComparison.OrdinalIgnoreCase) == 0)
{
dependentNodeName = ((FileNode)dependentNode).FileName;
break;
}

dependentNode = dependentNode.NextSibling;
}

Created Issue: SingleFileGenerator doesen't truncate the generated file in Iso-Shell [10727]

lesta — Mon, 11 Apr 2011 08:18:03 GMT

Created Issue: Navigation from Error Task list doesn't work anymore [10537]

Xomega — Sun, 27 Mar 2011 02:12:58 GMT

Navigation to a specific line/column in the document that has an error from the build error list doesn't work anymore.
In the previous version (MPF 9.0) the IDEBuildLogger.cs had a following line during ErrorTask creation:
task.Navigate += new EventHandler(NavigateTo);
and also had the corresponding NavigateTo method implemented. For some reason it is missing in the current MPF 10.0.